pkgs(pmtiles): init at 0-unstable-2025-12-29#1940
pkgs(pmtiles): init at 0-unstable-2025-12-29#1940Aman16102000 wants to merge 2 commits intongi-nix:mainfrom
Conversation
eljamm
left a comment
eljamm
left a comment
There was a problem hiding this comment.
Thanks for your contribution. In the future, if you see someone assigned to an issue, please ask them if they're currently working on it or if they need help before you tackle it, else we can end up duplicating efforts.
| src = fetchFromGitHub { | ||
| owner = "protomaps"; | ||
| repo = "PMTiles"; | ||
| rev = "754e15bf58fa3cd1491bbfd16d48d72a72602596"; # main branch as of 2025-01-06 |
There was a problem hiding this comment.
The comment is redundant. This is already clear from the version.
| rev = "754e15bf58fa3cd1491bbfd16d48d72a72602596"; # main branch as of 2025-01-06 | |
| rev = "754e15bf58fa3cd1491bbfd16d48d72a72602596"; |
| description = "Web viewer for PMTiles"; | ||
| homepage = "https://protomaps.com/docs/pmtiles"; | ||
| license = lib.licenses.bsd3; | ||
| maintainers = with lib.maintainers; [ ]; |
There was a problem hiding this comment.
| maintainers = with lib.maintainers; [ ]; | |
| teams = with lib.teams; [ ngi ]; |
There was a problem hiding this comment.
Add geospatial team as well.
|
|
||
| meta = { | ||
| description = "Web viewer for PMTiles"; | ||
| homepage = "https://protomaps.com/docs/pmtiles"; |
There was a problem hiding this comment.
| homepage = "https://protomaps.com/docs/pmtiles"; | |
| homepage = "https://docs.protomaps.com/pmtiles"; | |
| downloadPage = "https://github.com/protomaps/PMTiles"; |
There was a problem hiding this comment.
Please squash your commits and format the commit and PR titles in the following style: pkgs(pmtiles): init at 0-unstable-2025-12-29
|
|
||
| buildNpmPackage (finalAttrs: { | ||
| pname = "pmtiles-app"; | ||
| version = "0-unstable-2025-01-06"; |
There was a problem hiding this comment.
The commit date is 2025-12-29
| version = "0-unstable-2025-01-06"; | |
| version = "0-unstable-2025-12-29"; |
| }: | ||
|
|
||
| buildNpmPackage (finalAttrs: { | ||
| pname = "pmtiles-app"; |
There was a problem hiding this comment.
| pname = "pmtiles-app"; | |
| pname = "pmtiles"; |
There was a problem hiding this comment.
Upstream name is pmtiles-app. I would go with pmtiles-app.
|
Actually, it's probably better to call this 
|
|
@Aman16102000 , great thanks for you contribution. I am also Nixpkgs Geospatial team member and I am very happy to merge your contribution to nixpkgs . Or @eljamm @Aman16102000 , what about migrating this PR to nixpkgs straight away ? |
imincik
changed the title
3 participants
Fixes #1844
The package:
buildNpmPackageto build the web application from the protomaps/PMTiles repository/appdirectory from the repositoryshare/pmtiles-appfor servingTest Plan
nix build .#pmtiles-apppython3 -m http.server 8000 --directory result/share/pmtiles-app