refactor: coerce leaf test modules into derivations #1999
Draft
eljamm wants to merge 3 commits intongi-nix:mainfrom
Draft
refactor: coerce leaf test modules into derivations #1999eljamm wants to merge 3 commits intongi-nix:mainfrom
eljamm wants to merge 3 commits intongi-nix:mainfrom
Conversation
eljamm
force-pushed
the
refactor/module-composition-node-tests
branch
from
8282ea0 to
9d77c03
Compare
Contributor
Author
|
I think this works nicely, but one clear disadvantage is that this increases evaluation times for flake checks. Interestingly, the overview doesn't seem to be affected, which I think is because we're not accessing any attribute that would make it evaluate. |
eljamm
force-pushed
the
refactor/module-composition-node-tests
branch
from
b8d40ba to
2ce9eb9
Compare
which is much simpler than collecting all the modules and converting them later on. The result is also easier to work with since it's either null or a derivation, as opposed to it potentially being a path or a module.
This should be properly fixed in the future, but for now let's just get these working.
eljamm
force-pushed
the
refactor/module-composition-node-tests
branch
from
15f2712 to
5d26747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is much simpler than collecting all the modules and converting them later on. The result is also easier to work with since it's either null or a derivation, as opposed to it potentially being a path or a module.
For now, tests are still passed to
projects/tests.nix, which is fine since they should already be derivations. We will clean this up when we migrate away fromhydrated-projects.