CPU Profiling #1242
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # This script runs Go tests with CPU profiling enabled for all test packages found under the directories: | ||
| # - internal/watcher | ||
| # - test/integration | ||
| # It saves the CPU profiles in the $PROFILES_DIR directory with the format <package-name>_<test_type>.pprof | ||
| # e.g. <package-name>_watcher_cpu.pprof or <package-name>_integration_cpu.pprof | ||
|
|
||
| # The variables below can be set to customize the environment for the integration tests: | ||
| # Example using variables defined in our Makefile: | ||
| # TEST_ENV=ci CONTAINER_OS_TYPE=linux BUILD_TARGET=agent PACKAGES_REPO=nginxinc \ | ||
| # PACKAGE_NAME=nginx-agent BASE_IMAGE=ubuntu OS_VERSION=20.04 OS_RELEASE=focal \ | ||
| # DOCKERFILE_PATH=Dockerfile IMAGE_PATH=nginxinc/nginx-agent TAG=latest CONTAINER_NGINX_IMAGE_REGISTRY=docker.io \ | ||
| # ./scripts/performance/profiling.sh | ||
|
|
||
| set -e | ||
| set -o pipefail | ||
|
|
||
| PROFILES_DIR="build/test/profiles" | ||
| mkdir -p ${PROFILES_DIR} | ||
|
|
||
| # Run watcher tests with CPU profiling for each package | ||
| echo "Starting watcher tests with cpu profiling..." | ||
| packages=$(find internal/watcher -type f -name '*_test.go' -exec dirname {} \; | sort -u) | ||
|
There was a problem hiding this comment. Do we need to add a script? Could this be done in the make file ? There was a problem hiding this comment. It probably could but it's much nicer to do it in bash vs Makefile. If we expand our profiling later I don't want to bloat these Makefiles There was a problem hiding this comment. Ok I'm just not the biggest fan of adding scripts |
||
| echo "Found packages:" | ||
| echo "$packages" | ||
| for pkg in $packages; do | ||
| echo "Running tests in package: ${pkg}" | ||
| go test \ | ||
| -count 10 -timeout 3m \ | ||
| -cpuprofile "${PROFILES_DIR}/$(basename $pkg)_watcher_cpu.pprof" \ | ||
| "./${pkg}" || { echo "Tests failed in package: ${pkg}, but continuing..."; continue; } | ||
| echo "Profile saved to: ${PROFILES_DIR}/$(basename $pkg)_watcher_cpu.pprof" | ||
| done | ||
|
|
||
| ### Run integration tests with CPU profiling for each package | ||
aphralG marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| #echo "Starting integration tests cpu profiling tests..." | ||
| #packages=$(find test/integration -type f -name '*_test.go' -exec dirname {} \; | sort -u) | ||
| #echo "Found packages:" | ||
| #echo "$packages" | ||
| #for pkg in $packages; do | ||
| # echo "Running tests in package: ${pkg}" | ||
| # go test \ | ||
| # -count 3 -timeout 3m \ | ||
| # -cpuprofile "${PROFILES_DIR}/$(basename $pkg)_integration_cpu.pprof" \ | ||
| # "./${pkg}" || { echo "Tests failed in package: ${pkg}, but continuing..."; continue; } | ||
| # echo "Profile saved to: ${PROFILES_DIR}/$(basename $pkg)_integration_cpu.pprof" | ||
| #done | ||
|
|
||
| ## Merge all CPU profiles | ||
| files=$(ls ${PROFILES_DIR}/*.pprof) | ||
| echo "Merging CPU profiles: $files" | ||
| go tool pprof -proto -output=${PROFILES_DIR}/merged.pprof $files | ||
| echo "Merged CPU profile saved to: ${PROFILES_DIR}/merged.pprof" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/bin/bash | ||
|
|
||
| PROFILE=${PROFILE:-"false"} | ||
| BENCHMARKS_DIR="/agent/performance/load" | ||
|
|
||
| load_test() { | ||
| echo "Running load tests..." | ||
| pushd test/load | ||
| go test -v -timeout 1m ./... | ||
| cp benchmarks.json ${BENCHMARKS_DIR} | ||
| cp -r results ${BENCHMARKS_DIR} | ||
| popd | ||
| } | ||
|
|
||
| load_test_with_profile() { | ||
| echo "Running load tests with CPU Profiling enabled..." | ||
| pushd test/load | ||
| go test -v -timeout 1m ./... \ | ||
| -cpuprofile metrics_load_cpu.pprof | ||
| cp benchmarks.json ${BENCHMARKS_DIR} | ||
| cp -r results ${BENCHMARKS_DIR} | ||
| cp *.pprof ${BENCHMARKS_DIR} | ||
| popd | ||
| } | ||
|
|
||
| ## Main script execution starts here | ||
| mkdir -p ${BENCHMARKS_DIR} | ||
| echo "Running in $(pwd)" | ||
| if [[ "$PROFILE" == "true" ]]; then | ||
| echo "CPU Profiling is enabled." | ||
| load_test_with_profile || { echo "Load tests with cpu profiling failed"; exit 1; } | ||
| else | ||
| load_test || { echo "Load tests failed"; exit 1; } | ||
| fi | ||
| echo "Done." |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.