Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 20, 2025

Proposed changes

  • Instead of sending a message on the bus to inform the plugins of changes to the agent config, added a Reconfigure function to the plugins. This allows the message bus before it processes a message to check if its a config update, if it is it validates and updates the new changes, then call reconfigure on each of the plugins and handles the data plane response.
  • Add ability to modify labels when a change is made to the labels the otel collector if one exists is also updated and restarted with the new changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Nov 20, 2025
@aphralG aphralG requested a review from a team as a code owner November 20, 2025 15:14
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 24.70588% with 128 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.32%. Comparing base (b5fb1ce) to head (f52b495).
⚠️ Report is 3 commits behind head on remote-configuration-log.

Files with missing lines Patch % Lines
internal/bus/message_pipe.go 20.87% 71 Missing and 1 partial ⚠️
internal/collector/otel_collector_plugin.go 9.09% 10 Missing ⚠️
internal/config/mapper.go 0.00% 9 Missing ⚠️
api/grpc/mpi/v1/helpers.go 68.42% 6 Missing ⚠️
internal/command/command_plugin.go 53.84% 6 Missing ⚠️
internal/command/command_service.go 0.00% 6 Missing ⚠️
internal/file/file_plugin.go 0.00% 6 Missing ⚠️
internal/resource/resource_plugin.go 0.00% 6 Missing ⚠️
internal/watcher/watcher_plugin.go 0.00% 6 Missing ⚠️
internal/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           remote-configuration-log    #1402      +/-   ##
============================================================
- Coverage                     85.91%   85.32%   -0.59%     
============================================================
  Files                           102      102              
  Lines                         12741    12713      -28     
============================================================
- Hits                          10946    10848      -98     
- Misses                         1316     1388      +72     
+ Partials                        479      477       -2     
Files with missing lines Coverage Δ
internal/config/config.go 86.93% <100.00%> (-0.30%) ⬇️
internal/app.go 40.74% <0.00%> (ø)
api/grpc/mpi/v1/helpers.go 79.31% <68.42%> (-20.69%) ⬇️
internal/command/command_plugin.go 73.79% <53.84%> (+0.78%) ⬆️
internal/command/command_service.go 78.88% <0.00%> (-2.83%) ⬇️
internal/file/file_plugin.go 77.93% <0.00%> (+1.28%) ⬆️
internal/resource/resource_plugin.go 77.84% <0.00%> (+2.26%) ⬆️
internal/watcher/watcher_plugin.go 76.11% <0.00%> (+1.91%) ⬆️
internal/config/mapper.go 56.70% <0.00%> (-13.96%) ⬇️
internal/collector/otel_collector_plugin.go 80.96% <9.09%> (+0.08%) ⬆️
... and 1 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fb1ce...f52b495. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants