Skip to content

Conversation

@flybyray
Copy link

@flybyray flybyray commented Feb 23, 2025

Proposed changes

Allow overriding the current non generic name pattern.

e.g. to set "@nginx:1.24/common"

Checklist

Before creating a PR, run through this checklist and mark each as complete:

I just used github.com edit. not sure if i can edit multiple files in a simple change.

@flybyray flybyray requested a review from alessfg as a code owner February 23, 2025 21:20
@github-actions
Copy link

github-actions bot commented Feb 23, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@flybyray
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

I have hereby read the F5 CLA and agree to its terms

@alessfg alessfg changed the title Update install-distribution.yml feat: Allow overriding non generic name pattern in distribution Mar 11, 2025
@alessfg
Copy link
Member

alessfg commented Mar 11, 2025

Hey @flybyray! Thanks for your PR! Couple things:

  1. For signing the CLA, can you create a new comment without the comment quote?
  2. It would be great if you could update the Changelog and defaults/main/main.yml.

allow overriding the current non generic name pattern.

e.g. to set "@nginx:1.24/common"
fix "can only concatenate str"
@alessfg
Copy link
Member

alessfg commented Mar 24, 2025

Closing in favor of #877

@alessfg alessfg closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhance/improve an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants