Skip to content

Conversation

@alessfg
Copy link
Member

@alessfg alessfg commented May 2, 2025

Proposed changes

Add support for installing NGINX Open Source and NGINX Plus on Alpine Linux 3.21 and remove support for installing NGINX Plus on Alpine Linux 3.17.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

Copilot AI review requested due to automatic review settings May 2, 2025 19:23
@alessfg alessfg requested a review from a team as a code owner May 2, 2025 19:23
@alessfg alessfg self-assigned this May 2, 2025
@github-actions github-actions bot added breaking change Implies a breaking change enhancement Enhance/improve an existing feature labels May 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for Alpine Linux 3.17 and integrates Alpine Linux 3.21 support across the role and its associated Molecule tests, updating the configuration and documentation accordingly.

  • Update supported Alpine versions in vars/main.yml for both NGINX Open Source and NGINX Plus
  • Add new Alpine 3.21 platforms in various Molecule configuration files
  • Adjust CHANGELOG to reflect the breaking change and feature additions

Reviewed Changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vars/main.yml Updated supported Alpine versions and adjusted SLES versions
molecule/version/molecule.yml Removed Alpine 3.17 and added Alpine 3.21 platform
molecule/upgrade/molecule.yml Added Alpine 3.21 platform
molecule/upgrade-plus/molecule.yml Updated comment regarding Alpine version support
molecule/uninstall-plus/molecule.yml Added Alpine 3.21 platform
molecule/stable/molecule.yml Added Alpine 3.21 platform
molecule/source-version/molecule.yml Added Alpine 3.21 platform
molecule/plus/converge.yml Removed opentracing from the list of modules
molecule/downgrade/molecule.yml Added Alpine 3.21 platform
molecule/downgrade-plus/molecule.yml Revised Alpine platform entries and comments
molecule/default/molecule.yml Added a new Alpine platform, but with a version mismatch
CHANGELOG.md Updated version and breaking change notes
Files not reviewed (4)
  • molecule/distribution/molecule.yml: Language not supported
  • molecule/plus/molecule.yml: Language not supported
  • molecule/source/molecule.yml: Language not supported
  • molecule/uninstall/molecule.yml: Language not supported
Comments suppressed due to low confidence (1)

molecule/default/molecule.yml:46

  • The platform is named 'alpine-3.21' but the Docker image is set to 'alpine:3.22'. Please verify whether this is intentional or adjust the image version to match the platform name.
    image: alpine:3.22

@alessfg alessfg added this to the 0.25.1 milestone May 2, 2025
@alessfg alessfg force-pushed the update-distros branch 2 times, most recently from 3779532 to af6fdaf Compare May 4, 2025 21:27
@alessfg alessfg enabled auto-merge May 5, 2025 15:19
@alessfg alessfg added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 2f56b87 May 5, 2025
20 checks passed
@alessfg alessfg deleted the update-distros branch May 5, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Implies a breaking change enhancement Enhance/improve an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants