Skip to content

Conversation

@alessfg
Copy link
Member

@alessfg alessfg commented May 6, 2025

Proposed changes

Add a parameter, nginx_skip_os_install_config_check, to turn off the NGINX config check handler when installing NGINX from the respective distribution package manager. This should help avoid potential issues where the default NGINX config that ships with a distribution is broken for some reason. Resolves #888

Checklist

Before creating a PR, run through this checklist and mark each as complete:

Copilot AI review requested due to automatic review settings May 6, 2025 20:23
@alessfg alessfg requested a review from a team as a code owner May 6, 2025 20:23
@github-actions github-actions bot added the enhancement Enhance/improve an existing feature label May 6, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new parameter, nginx_skip_os_install_config_check, to disable the NGINX config check when installing from an OS repository, addressing scenarios where the default configuration might be broken.

  • Updated the handler condition to include the new parameter.
  • Documented the new parameter in the defaults file and updated the CHANGELOG accordingly.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
handlers/main.yml Updated when condition to include nginx_skip_os_install_config_check, which may have a logical error in its operator precedence.
defaults/main/main.yml Added documentation (as commented examples) for the new parameter.
CHANGELOG.md Added an entry describing the new parameter addition.

@alessfg alessfg self-assigned this May 6, 2025
@alessfg alessfg added this to the 0.25.1 milestone May 6, 2025
@alessfg alessfg changed the title feat: Add option to skip config check when installing from an OS repo feat: Allow to skip config check when installing from an OS repo May 6, 2025
@alessfg alessfg force-pushed the make-config-check-optional branch from 55c7c0d to 0bbc475 Compare May 6, 2025 20:31
@alessfg alessfg changed the title feat: Allow to skip config check when installing from an OS repo feat: Allow skipping config check when installing from an OS repo May 6, 2025
@alessfg alessfg changed the title feat: Allow skipping config check when installing from an OS repo feat: Allow skipping config check when installing NGINX from an OS repo May 6, 2025
@alessfg alessfg enabled auto-merge May 6, 2025 22:16
@alessfg alessfg added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit b401deb May 6, 2025
20 checks passed
@alessfg alessfg deleted the make-config-check-optional branch May 6, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhance/improve an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Role fails with check handler when installing on OS with IPv6 disabled

3 participants