fix: Use temp file for IPv6 conf checksum (#228)#377
fix: Use temp file for IPv6 conf checksum (#228)#377dalees wants to merge 1 commit intonginx:mainfrom
Conversation
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
|
@alessfg do you have some time to review this? |
alessfg
changed the title
|
Hey @dalees! Can you rebase your branch and check your fork settings? The pipelines aren't running and I wonder if it might be related 🙂 cc @thresheek |
There was a problem hiding this comment.
Pull request overview
This PR fixes IPv6 auto-enable being skipped on startup by making the packaged-config checksum comparison account for the image’s default.conf port rewrite (80 → 8080) via a temporary “reverted” config.
Changes:
- Create a temporary copy of
/etc/nginx/conf.d/default.confwith the listen port reverted to 80 for checksum comparison. - Use the temp file for Debian (md5) and Alpine (sha1) conffile checksum verification before enabling IPv6 listen.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The conf file was modified to change listen port in the Dockerfile, so to correctly compare packaged checksums we create a temporary file with the known changes reverted. This resolves an issue where the container would never listen on IPv6 on startup.
Thanks for checking this PR! I've now rebased the branch, addressed suggestions from copilot, and checked I'm not sure what the pipelines need to run, but there might be an approval needed. https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks |
2 participants
Proposed changes
The conf file has been modified to change listen port in the Dockerfile, so to correctly compare packaged checksums we create a temporary file with the known changes reverted.
This resolves an issue where the container would never listen on IPv6 on startup.
resolves #228 #114
Checklist
Before creating a PR, run through this checklist and mark each as complete:
update.shscript and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & DockerfilesREADMEfor more details)README.md)