Skip to content

Conversation

rishabh-f5
Copy link
Contributor

@rishabh-f5 rishabh-f5 commented Aug 22, 2025

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Screenshot 2025-08-22 at 8 04 09 PM

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@rishabh-f5 rishabh-f5 requested a review from a team as a code owner August 22, 2025 05:23
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure labels Aug 22, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you've removed /tmp and /var/cache/nginx from the table. Is this intentional? Do we no longer support writes to these directories?

If so, I'm concerned this might be a "breaking change".

@rishabh-f5 rishabh-f5 requested review from mjang and ryepup September 4, 2025 06:28
@rishabh-f5 rishabh-f5 requested a review from mjang September 9, 2025 16:08
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@rishabh-f5 rishabh-f5 requested review from mjang and ryepup September 15, 2025 07:14
@rishabh-f5 rishabh-f5 requested a review from ryepup September 15, 2025 14:33
@russokj
Copy link
Contributor

russokj commented Sep 17, 2025

Do we need to document /var/log/nginx, /var/log/app_protect (or maybe just /var/log)?
(I guess strictly speaking, we don't upload to /var/log, but the configs we upload can reference them and I believe the section is title NGINX filesystem restrictions )
@arpith-f5, @edarzins, or @arussellf5 - any thoughts?

@arpith-f5
Copy link
Contributor

Do we need to document /var/log/nginx, /var/log/app_protect (or maybe just /var/log)? (I guess strictly speaking, we don't upload to /var/log, but the configs we upload can reference them and I believe the section is title NGINX filesystem restrictions ) @arpith-f5, @edarzins, or @arussellf5 - any thoughts?

Looking at the previously resolved conversation. Looks like there has been a discussion on this already. #1020 (comment). This is a table showing where users can upload files so would probably be confusing to add the log directory as well.

@russokj russokj merged commit 60bb426 into nginx:main Sep 18, 2025
6 checks passed
@rishabh-f5 rishabh-f5 deleted the NLB-5699-improve-docs-on-allowed-directories branch October 21, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nginxaas-azure Issues related to NGINX as a Service for Azure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants