generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 110
Nlb 6573 update nap doc file path change #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kafeelhasan
wants to merge
9
commits into
nginx:main
Choose a base branch
from
kafeelhasan:NLB-6573-Update-NAP-doc-filePath-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nlb 6573 update nap doc file path change #1048
kafeelhasan
wants to merge
9
commits into
nginx:main
from
kafeelhasan:NLB-6573-Update-NAP-doc-filePath-change
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the NAP user facing documentation with the following change: Based on this issue : nginxinc/nalb-shared#1695, updated the Configure App Protect WAF with the following text - The File path is not optional and is automatically generated in the portal, defaulting to the path “/etc/app_protect/conf/” plus the policy Name with a “.json” extension
mjang
approved these changes
Sep 2, 2025
@kafeelhasan , based on the previous PR, I probably merged too early. My bad. Let me know when you think this is ready for merge. |
y82
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
product/nginxaas
Issues related to NGINX as a Service for Azure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As per Issue : https://github.com/nginxinc/nalb-shared/issues/1695 Updated the documentation to have .json extension to the File Path. Screenshot below :
Closed PR : #1041
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩