Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Sep 4, 2025

Proposed changes

Update: now made an implicit part of #1057 (I've set up this PR against the branch of #1057 )

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@mjang mjang requested a review from y82 September 4, 2025 13:47
@mjang mjang self-assigned this Sep 4, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) labels Sep 4, 2025
@mjang mjang changed the title Feat feature compare noss nplus feat: Link to comparison between N OSS and N Plus Sep 4, 2025
@travisamartin
Copy link
Contributor

Should this PR target the branch in #1057 instead of main?

@mjang
Copy link
Contributor Author

mjang commented Sep 12, 2025

Should this PR target the branch in #1057 instead of main?

Oh... that's how I get around the build failure! (I was going to wait until after #1057 is merged)

@mjang mjang changed the base branch from main to nginxaas/add-comparison-link September 12, 2025 13:33
@mjang mjang marked this pull request as ready for review September 12, 2025 13:33
@mjang mjang requested a review from a team as a code owner September 12, 2025 13:33
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1061/

@mjang mjang mentioned this pull request Sep 12, 2025
5 tasks
@mjang mjang merged commit 72b1b9f into nginxaas/add-comparison-link Sep 12, 2025
7 checks passed
@mjang mjang deleted the feat-feature-compare-noss-nplus branch September 12, 2025 13:49
JTorreG added a commit that referenced this pull request Sep 12, 2025
* docs: add comparison include

* docs: convert to feture page

* docs: move callout to bottom

* Update content/includes/nginx-plus/oss-plus-comparison.md

Co-authored-by: Travis Martin <[email protected]>

* Apply suggestion from @mjang

* feat: Link to comparison between N OSS and N Plus (#1061)

* feat: add comparison: OSS v. Plus

* replace with include

---------

Co-authored-by: Mike Jang <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants