WAF enforcer-only upgrade comment #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update deploy-with-kic.md * Update deploy-with-kic.md --------- Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Mike Jang <[email protected]>
* feat: Update pull request template This commit fixes the spacing issue of the pull request checklist by changing the final checklist item. The relevant information now exists as a sentence after the list, as well as an additional line. The additional line, alongside a similar one added to the checklist, direct the reader to our style guide to review specific guidance that would otherwise be too verbose to add to the template.
* linkchecker update ignore list * update links to kic docs
…nx#81) With the newly open source documentation repository, we can now consolidate all NGINX documentation into one place. This has a lots of benefits which include but are not limited to more effective content re-use, pipeline engineering and style enforcement. This commit adds all of the content for NGINX Gateway Fabric, and updates all relevant folder and file names, including link references. Once this content has been successfully deployed, a PR to remove all documentation traces and tooling will be opened in the Gateway Fabric repository, decoupling the documentation fully. It also updates the frontmatter of every single page in the documentation set. They are now all consistent in their fields and formatting, and a handful of IA or heading changes have been made as low-hanging fruit to bring the documentation set closer to full consistency.
…ses" (nginx#91) * Add log monitoring examples and guidance to "About subscription licenses" * added log warnings to include
* Update tech-specs.md to include NAP Co-authored-by: Daniel Edgar <[email protected]> --------- Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Daniel Edgar <[email protected]> Co-authored-by: Mike Jang <[email protected]>
…#102) This commit adds an explicit URL to the subfolders of the NGINX Gateway Fabric set, which is inherited by the pages within the folders. It is necessary for URLs to resolve sensibly, as otherwise they default to the folder path, /ngf/, which we do not map as part of the deployment.
…#103) The pull request template currently renders incorrectly due to a lack of spacing within the square brackets. The spaces looked optional in GitHub documentation, and the issue was not obvious until merged and used.
|
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms 6 out of 7 committers have signed the CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: WAF enforcer-only upgrade
Solution: Version matching requirements are added
Checklist
Before merging a pull request, run through this checklist and mark each as complete.