Skip to content

Conversation

ADubhlaoich
Copy link
Member

Proposed changes

This commit adds the NGINX Gateway Fabric team as codeowners of the NGF subfolders related to the product, ensuring they get tagged when relevant. As part of this change, I have also alphabetized the teams and adjusting the spacing for readability.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

This commit adds the NGINX Gateway Fabric team as codeowners of the
NGF subfolders related to the product, ensuring they get tagged when
relevant. As part of this change, I have also alphabetized the teams and
adjusting the spacing for readability.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner January 27, 2025 16:19
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/117/

@ADubhlaoich
Copy link
Member Author

The CODEOWNERS file issue confirms something I've suspected: the product teams' permissions haven't been set up correctly.

Flagged it to engineering - the teams weren't being tagged for PRs.

Co-authored-by: Jodie Putrino <[email protected]>
@ADubhlaoich ADubhlaoich merged commit 15d93bd into main Jan 28, 2025
8 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/add-ngf-codeowners branch January 28, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants