-
Notifications
You must be signed in to change notification settings - Fork 118
Update nginx one metrics #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nginx one metrics #1291
Conversation
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms 0 out of 2 committers have signed the CLA. |
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattdesmarais I think I understand what you've done. The user needs to do more to enable N+ metrics (instead of just N OSS metrics).
I've suggested changes that conform to our style guide. Specifically, we recommend the use of "active voice" (so audiences know they have to do something).
content/includes/use-cases/monitoring/enable-nginx-plus-status-zone-limited.md
Outdated
Show resolved
Hide resolved
content/includes/use-cases/monitoring/enable-nginx-plus-status-zone-limited.md
Show resolved
Hide resolved
content/includes/use-cases/monitoring/enable-nginx-plus-status-zone-limited.md
Outdated
Show resolved
Hide resolved
content/includes/use-cases/monitoring/enable-nginx-plus-status-zone-limited.md
Show resolved
Hide resolved
…-zone-limited.md Co-authored-by: Mike Jang <[email protected]>
…-zone-limited.md Co-authored-by: Mike Jang <[email protected]>
Co-authored-by: Mike Jang <[email protected]>
Proposed changes
This update clarifies that the status_zone directive is required for NGINX Plus metrics to be collected and displayed in NGINX Console. Without it, the Plus API will not populate metrics and the Agent will not send data.
The text has also been revised to align with current NGINX Console terminology — specifically, to reflect that both the Dashboard and Instances Metrics views display collected data.