Skip to content

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Oct 15, 2025

Proposed changes

PR #1284 accidentally removes a line that is part of the N1 Console telemetry details.
Context: https://github.com/nginx/documentation/pull/1284/files#r2429787247

This change re add this line.

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@shaun-nx shaun-nx marked this pull request as ready for review October 15, 2025 08:26
@shaun-nx shaun-nx requested a review from a team as a code owner October 15, 2025 08:26
@github-actions github-actions bot added documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric labels Oct 15, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1309/

Comment on lines 60 to 61
Add the `--product-telemetry-disable` flag to the `nginx-gateway` container in your Deployment manifest.
Add the `--product-telemetry-disable` flag to the `nginx-gateway` container in your Deployment manifest.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this is highlighting a difference, pasted into a diff checker and it shows 0 difference.

Copy link
Contributor

@mjang mjang Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No biggie. A local git diff from the CLI shows:

Screenshot 2025-10-17 at 12 55 36 PM

If you can approve @bjee19 , we can push this out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep seems fine

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm

@mjang mjang merged commit c24ac3d into main Oct 17, 2025
9 checks passed
@mjang mjang deleted the ngf/telemetry-n1console branch October 17, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants