-
Notifications
You must be signed in to change notification settings - Fork 119
Re add missing line for N1 Console telemetry #1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
Add the `--product-telemetry-disable` flag to the `nginx-gateway` container in your Deployment manifest. | ||
Add the `--product-telemetry-disable` flag to the `nginx-gateway` container in your Deployment manifest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this is highlighting a difference, pasted into a diff checker and it shows 0 difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm
Proposed changes
PR #1284 accidentally removes a line that is part of the N1 Console telemetry details.
Context: https://github.com/nginx/documentation/pull/1284/files#r2429787247
This change re add this line.
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩