Skip to content

Conversation

@balakoteswar
Copy link
Contributor

@balakoteswar balakoteswar commented Feb 12, 2025

Proposed changes

Updated the compatibility matrices in Technical Specifications for NGINX App Protect Releases 4.13.0 and 5.5.0. Also updated the nms-nap-compiler versions that correspond to those NAP releases.

Testing: Tested locally.

Closes # N/A

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@balakoteswar balakoteswar requested a review from a team as a code owner February 12, 2025 05:07
@github-actions
Copy link

github-actions bot commented Feb 12, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@balakoteswar
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@balakoteswar This is a completely open source repository, visible to the public.

You should remove the link to the internal work resource: the pull request template specifies to link a GitHub issue if applicable.

@balakoteswar
Copy link
Contributor Author

LGTM!

@balakoteswar This is a completely open source repository, visible to the public.

You should remove the link to the internal work resource: the pull request template specifies to link a GitHub issue if applicable.

Thanks, @ADubhlaoich, I have removed the link.

@travisamartin travisamartin merged commit 5f5420c into nginx:main Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants