Skip to content

Conversation

@nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Feb 17, 2025

Proposed changes

Use full path for cost calculator imports temporarily.
The cost calculator should use the normal hugo approach to pulling in scripts and css, but this will fix the nginxaas migration for now.

note This will not work in previews, only in dev/staging/production where the hardcoded url matches.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@nginx-jack nginx-jack requested a review from a team as a code owner February 17, 2025 16:19
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/198/

@JTorreG JTorreG merged commit 39c847a into main Feb 17, 2025
12 checks passed
@JTorreG JTorreG deleted the fix-cost-calculator branch February 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants