Skip to content

Conversation

@balakoteswar
Copy link
Contributor

@balakoteswar balakoteswar commented Feb 18, 2025

Proposed changes

  • Updated tech specs table for NIM to support ubuntu24
  • Fixed syntax errors causing make docs/make watch failure.

Testing: Local testing performed.
NIM Tech spec Table:
Screenshot 2025-02-18 at 7 05 06 PM

Fixed a couple of syntax errors for NGNIX docs:
Screenshot 2025-02-18 at 7 15 04 PM
Screenshot 2025-02-18 at 7 15 50 PM

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@balakoteswar balakoteswar requested a review from a team as a code owner February 18, 2025 13:51
Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with 1 nit

@mjang mjang merged commit fd8fe65 into nginx:main Feb 18, 2025
5 checks passed
travisamartin added a commit that referenced this pull request Jun 16, 2025
edits to helm deploy for lightweight mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants