Skip to content

Conversation

@mjang
Copy link
Contributor

@mjang mjang commented Dec 10, 2024

Proposed changes

After discussion, updated LICENSE file to match nginx.org (BSD 2-clause simplified license)
Also updated CONTRIBUTING.md for clarity

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines.
  • I have signed the F5 Contributor License Agreement (CLA).
  • If applicable, I have added tests that prove my fix is effective or that my feature works.
  • If applicable, I have checked that any relevant tests pass after adding my changes.
  • I have updated any relevant documentation (README.md and CHANGELOG.md).
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
  • If the change involves:
    • Code
    • Anything that resembles Personally identifying information (PII)
    • URLs
    • Significant new/revised content
      The change will require at least two (2) approvals before merging. One requirement: use placeholders such as <JWT Token> in place of PII

@mjang mjang self-assigned this Dec 10, 2024
@mjang mjang requested a review from a team as a code owner December 10, 2024 15:52
@mjang mjang marked this pull request as draft December 10, 2024 16:31
@mjang mjang marked this pull request as ready for review December 10, 2024 16:33
@mjang mjang changed the title fix: updates fix: Set license to BSD 2-clause. Update CONTRIBUTING. Dec 10, 2024
LICENSE Outdated
Creative Commons may be contacted at creativecommons.org.
/*
* Copyright (C) 2002-2021 Igor Sysoev
* Copyright (C) 2011-2024 Nginx, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm checking into whether this should be updated to include "F5, Inc". OK to merge as-is, we can always make the change once the question is settled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. If we do require "F5, Inc". we may also need to update https://github.com/nginx/nginx/blob/master/LICENSE

@mjang mjang force-pushed the fix-update-license-consistent branch from dfd098b to 7fc50eb Compare December 10, 2024 19:21
@mjang mjang merged commit 48e07cb into main Dec 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants