Skip to content

docs: NGF - add more context to Secret duplication #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

docs: NGF - add more context to Secret duplication #262

merged 1 commit into from
Mar 11, 2025

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Mar 6, 2025 •
edited
Loading

Mention that users can update the original Secrets to propagate changes to duplicate Secrets.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@sjberman
docs: NGF - add more context to Secret duplication
3681652 
Mention that users can update the original Secrets to propagate changes to duplicate Secrets.
@sjberman sjberman requested a review from a team March 6, 2025 15:26
@sjberman sjberman requested a review from a team as a code owner March 6, 2025 15:26
ADubhlaoich
ADubhlaoich approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JTorreG JTorreG added the product/ngf Issues related to NGINX Gateway Fabric label Mar 11, 2025
@sjberman sjberman merged commit 0e28f7f into nginx:ngf-feature-cp-dp-split Mar 11, 2025
5 checks passed
@sjberman sjberman deleted the docs/ngf-secrets branch March 11, 2025 13:43
bjee19 pushed a commit that referenced this pull request Apr 28, 2025
@sjberman @bjee19
docs: NGF - add more context to Secret duplication (#262)
658af5f 
Mention that users can update the original Secrets to propagate changes to duplicate Secrets.
bjee19 pushed a commit to bjee19/documentation that referenced this pull request Apr 28, 2025
@sjberman @bjee19
docs: NGF - add more context to Secret duplication (nginx#262)
53a6325 
Mention that users can update the original Secrets to propagate changes to duplicate Secrets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@JTorreG JTorreG JTorreG approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees

No one assigned

Labels

product/ngf Issues related to NGINX Gateway Fabric

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjberman @ADubhlaoich @JTorreG @bjee19