Skip to content

Conversation

ADubhlaoich
Copy link
Member

@ADubhlaoich ADubhlaoich commented Mar 13, 2025

Proposed changes

This pull request covers the release of NGINX App Protect WAF 5.6 and 4.14.

It updates the release notes, and also begins the process of reducing noise from the documentation set by removing deprecated instructions and consolidating duplicate information.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

* feat: install nap 5 with helm chart

* Update content/nap-waf/v5/admin-guide/deploy-on-kubernetes/deploy-with-helm.md

Co-authored-by: Jon Torre <[email protected]>
@ADubhlaoich ADubhlaoich self-assigned this Mar 13, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX labels Mar 13, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/280/

@ADubhlaoich ADubhlaoich changed the title NGINX App Protect 5.6 NGINX App Protect WAF 5.6 Mar 13, 2025
@ADubhlaoich ADubhlaoich changed the title NGINX App Protect WAF 5.6 NGINX App Protect WAF 5.6 / 4.14 Mar 13, 2025
@ADubhlaoich ADubhlaoich linked an issue Mar 27, 2025 that may be closed by this pull request
6 tasks
removing && from DanielK's comments
remove also for plus
@ADubhlaoich ADubhlaoich marked this pull request as ready for review March 31, 2025 14:35
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner March 31, 2025 14:35
ADubhlaoich and others added 2 commits April 1, 2025 12:54
remove mtls & read-only references due to a bug, need to fix that after release
update login with jwt
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting as 2nd approval, as all comments have been addressed.

@mjang mjang merged commit d39cae6 into main Apr 1, 2025
9 checks passed
@mjang mjang deleted the nap-release-5.6 branch April 1, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add JWT license information to NGINX App Protect WAF documentation

6 participants