Skip to content

Conversation

ADubhlaoich
Copy link
Member

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@ADubhlaoich ADubhlaoich requested a review from a team as a code owner March 13, 2025 16:10
@ADubhlaoich ADubhlaoich merged commit 8796d51 into nap-release-5.6 Mar 13, 2025
3 checks passed
@ADubhlaoich ADubhlaoich deleted the nap/add-5.6-rns branch March 13, 2025 16:10
@github-actions github-actions bot added documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX labels Mar 13, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/284/

mjang added a commit that referenced this pull request Apr 1, 2025
* Nap helm chart (#267)

* feat: install nap 5 with helm chart

* Update content/nap-waf/v5/admin-guide/deploy-on-kubernetes/deploy-with-helm.md

Co-authored-by: Jon Torre <[email protected]>

* feat: Add placeholders for NAP 5.6 / 4.14 release notes (#284)

* feat: Restructure Kubernetes documentation IA, update references

* feat: Re-order admin-guide pages

* Update content/nap-waf/v4/releases/about-4.14.md

* feat: Remove unnecessary item, move issues from known to resolved

* feat: Update Generated Documentation (#301)

Compiler 11.322.0-nap-release-4-14-0-13891737 (6d34e452)

* Apply suggestions from code review

Co-authored-by: ohad-perets <[email protected]>

* feat: Update package names, move Go version bump to resolved issues

* feat: Convert K8s configuration to includes for both cases

* feat: Remove mention of Alpine 3.17

* feat: OS version consolidation, remove redundancy

* feat: Add JWT step using includes

* feat: Update text to be imperative

* feat: Additional tab work for NAP5 installation

* feat: Fix formatting of common steps

* feat: Update release dates

* Update deploy-on-docker.md

removing && from DanielK's comments

* Update deploy-on-docker.md

remove also for plus

* feat: Update package file versions

* feat: Push additional documentation improvements

* feat: Fix links

* Update content/nap-waf/v5/releases/about-5.4.md

* Update deploy-with-helm.md

remove mtls & read-only references due to a bug, need to fix that after release

* Update deploy-with-helm.md

update login with jwt

---------

Co-authored-by: liadlevif5 <[email protected]>
Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: ohad-perets <[email protected]>
Co-authored-by: Mike Jang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant