Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Dec 30, 2024

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines.

  • I have signed the F5 Contributor License Agreement (CLA).

  • If applicable, I have added tests that prove my fix is effective or that my feature works.

  • If applicable, I have checked that any relevant tests pass after adding my changes.

  • I have updated any relevant documentation (README.md and CHANGELOG.md).

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging.

@mjang mjang requested a review from a team as a code owner December 30, 2024 14:55
@mjang mjang marked this pull request as draft December 30, 2024 14:55
@mjang mjang force-pushed the feat-readme-updates branch from 0d189fd to 6a8d994 Compare December 30, 2024 16:05
- Sync Code of Conduct info to template-repository
- Update pull request template for spacing issue
- Include notes on private/public repo info to F5-NGINX-team-notes file
@mjang mjang force-pushed the feat-readme-updates branch from 7ffca72 to 4a50582 Compare December 30, 2024 17:53
@mjang mjang self-assigned this Dec 30, 2024
@mjang mjang marked this pull request as ready for review December 30, 2024 17:54
@mjang mjang merged commit bd7100f into main Dec 30, 2024
3 of 5 checks passed
@mjang mjang deleted the feat-readme-updates branch December 30, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants