Skip to content

Conversation

y82
Copy link
Contributor

@y82 y82 commented Apr 8, 2025

Proposed changes

This is a big update of OpenTelemetry dynamic module page.

  • new intro
  • added prerequisites
  • added sudo and dnf update
  • updated linux commands to be copy-pasteable
  • refactored linux commands to look more friendly
  • removed unneeded duplication of reference as the official module docs are on nginx.org
  • added descriptions for examples
  • removed unneeded html (spans)
  • tested with Ubuntu and FreeBSD

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@y82 y82 requested a review from a team as a code owner April 8, 2025 10:21
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) labels Apr 8, 2025
@y82 y82 requested a review from JTorreG April 8, 2025 11:31
@y82 y82 enabled auto-merge (squash) April 8, 2025 13:21
@y82 y82 self-assigned this Apr 9, 2025
@y82 y82 disabled auto-merge April 10, 2025 09:37
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, about a line that confused me

@y82 y82 requested a review from mjang April 10, 2025 14:44
@y82 y82 enabled auto-merge (squash) April 10, 2025 14:44
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@y82 y82 merged commit cbc4187 into nginx:main Apr 10, 2025
4 checks passed
@y82 y82 deleted the otel branch April 10, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants