Skip to content

Update CODEOWNERS file #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Update CODEOWNERS file #386

merged 1 commit into from
Apr 10, 2025

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Apr 10, 2025 •
edited
Loading

Proposed changes

Fixes the name of the N4A approvers team in the CODEOWNERS file. This will allow the team members to approve pull requests related to NGINXaaS for Azure content.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@jputrino
Update CODEOWNERS file
ba01bf7 
Fixes the name of the N4A approvers team.
@jputrino jputrino requested a review from a team April 10, 2025 14:41
@jputrino jputrino requested a review from a team as a code owner April 10, 2025 14:41
@jputrino jputrino self-assigned this Apr 10, 2025
@github-actions github-actions bot added the tooling Back end, repository, Hugo, and all things not related to content label Apr 10, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/386/

mjang
mjang approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah hah -- I can see https://github.com/orgs/nginx/teams/n4a-docs-approvers

@jputrino jputrino merged commit e2295ed into main Apr 10, 2025
9 checks passed
@jputrino jputrino deleted the jputrino-codeowners-update branch April 10, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryepup ryepup ryepup approved these changes

@mjang mjang mjang approved these changes

Assignees

@jputrino jputrino

Labels

tooling Back end, repository, Hugo, and all things not related to content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jputrino @ryepup @mjang