Skip to content

Conversation

y82
Copy link
Contributor

@y82 y82 commented Apr 23, 2025

Patch 1: Added procedure for DNS active health check.

  • detailed configuration of active health checks for DNS
  • intro and "see also" added
  • a href and span html removed

Patch 2: Minor fixes in TCP/UDP load balancing

  • broken link to nginx.com fixed
  • span html tag converted to id tag
  • API version updated to 9
  • "See also" added

Tested locally with Hugo preview
Closes #401

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@y82 y82 requested a review from a team as a code owner April 23, 2025 10:28
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) labels Apr 23, 2025
@y82 y82 self-assigned this Apr 23, 2025
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@y82 y82 merged commit b2dd73f into nginx:main Apr 23, 2025
6 checks passed
@y82 y82 deleted the dns-hc branch April 23, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example Test for DNS is not helpful

3 participants