Skip to content

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented May 2, 2025

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users need a how to guide on how to scale control plane and data plane

Solution: Introduces a new how-to guide on scaling control and data plane pods

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

nginx/nginx-gateway-fabric#3235

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) product/ngf Issues related to NGINX Gateway Fabric product/nginx-one Issues related to NGINX One Console product/nginxaas-azure Issues related to NGINX as a Service for Azure product/agent Issues related to NGINX Agent tooling Back end, repository, Hugo, and all things not related to content process documentation Documentation related to how the repository or documention itself is managed. product/dos Issues related to F5 DoS for NGINX product/waf Issues related to F5 WAF for NGINX labels May 2, 2025
@salonichf5 salonichf5 force-pushed the docs/scaling-ngf branch 3 times, most recently from 679132d to 176e95a Compare May 2, 2025 18:06
@salonichf5 salonichf5 marked this pull request as ready for review May 2, 2025 18:11
@salonichf5 salonichf5 requested a review from a team as a code owner May 2, 2025 18:11
@salonichf5 salonichf5 force-pushed the docs/scaling-ngf branch 2 times, most recently from ebce7a6 to b6768d3 Compare May 2, 2025 18:16
@salonichf5 salonichf5 requested a review from a team May 2, 2025 19:46
salonichf5 and others added 2 commits May 7, 2025 00:31
@salonichf5 salonichf5 requested a review from sjberman May 6, 2025 20:11
@sjberman sjberman removed product/nim Issues related to NGINX Instance Manager product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) product/nginx-one Issues related to NGINX One Console product/nginxaas-azure Issues related to NGINX as a Service for Azure product/agent Issues related to NGINX Agent tooling Back end, repository, Hugo, and all things not related to content process documentation Documentation related to how the repository or documention itself is managed. product/dos Issues related to F5 DoS for NGINX product/waf Issues related to F5 WAF for NGINX labels May 6, 2025
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good to me after single change, i'll defer to @ADubhlaoich to any stylistic docs changes

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, sorry about the edit suggestions.

@salonichf5 salonichf5 requested a review from ADubhlaoich May 7, 2025 16:09
@salonichf5 salonichf5 requested a review from sjberman May 7, 2025 20:03
@salonichf5 salonichf5 requested a review from sjberman May 7, 2025 20:14
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM!

@salonichf5 salonichf5 merged commit 5c7a698 into nginx:ngf-feature-cp-dp-split May 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants