-
Notifications
You must be signed in to change notification settings - Fork 120
NGF: Upgrade NGF from 1.x to 2.x #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c9bc7ef to
201fb04
Compare
7147105 to
527d8d9
Compare
6a8f7be to
482e8c2
Compare
16ee0c1 to
13be7da
Compare
✅ Deploy Preview will be available once build job completes!
|
7ab7aed to
93f159b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, made some edit suggestions.
I may do a second pass on the document as part of work in the release branch.
6878748 to
27c47ad
Compare
f3cec56 to
0e31a06
Compare
0e31a06 to
ae3e590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users need documentation to upgrade from NGF v1.6.x to v2.0.x
Solution: Adds an upgrade document with instructions to upgrade
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
nginx/nginx-gateway-fabric#3241
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.mdandCHANGELOG.mdFootnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩