Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jan 13, 2025

Proposed changes

Problem: @Jcahilltorre discovered draft: true content, in this file , which hides all content in the respective subdirectories -- which includes this file.

Fortunately, the content already exists in this location

Solution: I've therefore deleted this directory and all contents, since they're essentially duplicate content. I think we should keep the Settings directory, as it is an option in the NGINX One Console

Testing: I did a diff with the duplicate content, and found -0- difference.

Closes #54

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mjang mjang marked this pull request as ready for review January 13, 2025 15:42
@mjang mjang requested a review from a team as a code owner January 13, 2025 15:42
@mjang mjang self-assigned this Jan 13, 2025
@mjang mjang requested a review from JTorreG January 13, 2025 15:42
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/61/

@mjang mjang added the bug Something isn't working label Jan 13, 2025
@mjang mjang force-pushed the fix-remove-content-previously-moved branch from 287d67e to 441ee2c Compare January 14, 2025 13:35
@mjang
Copy link
Contributor Author

mjang commented Jan 14, 2025

Merging without a 2nd approval due to the minor nature of this change.

@mjang mjang merged commit ecee3c0 into main Jan 14, 2025
4 of 5 checks passed
@mjang mjang deleted the fix-remove-content-previously-moved branch January 14, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accidentally hidden content, NGINX One

2 participants