Skip to content

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jan 14, 2025

Proposed changes

Based on #62

Here's a screenshot of the build of my proposed change:
Screenshot 2025-01-14 at 7 36 46 AM

Closes #62

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mjang mjang added the enhancement New feature or request label Jan 14, 2025
@mjang mjang self-assigned this Jan 14, 2025
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/66/

@mjang mjang marked this pull request as ready for review January 14, 2025 15:37
@mjang mjang requested a review from a team as a code owner January 14, 2025 15:37
@mjang
Copy link
Contributor Author

mjang commented Jan 14, 2025

Merging based on @bwolmarans 's approval (as a 2nd approval) in an internal chat.

@mjang mjang merged commit f832350 into main Jan 14, 2025
4 of 5 checks passed
@mjang mjang deleted the fix-cert-status-table branch January 14, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NGINX One: Set up certificate status options as a table

2 participants