Skip to content

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

NGINX Ingress Controller Release 5.1.0

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

Copy link

github-actions bot commented Jun 23, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation tooling Back end, repository, Hugo, and all things not related to content product/nic Issues related to NGINX Ingress Controller labels Jun 23, 2025
@AlexFenlon
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

1 similar comment
@pdabelf5
Copy link
Contributor

I have hereby read the F5 CLA and agree to its terms

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/730/

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM: some non-blocking suggestions for grammar in the release notes.

@AlexFenlon AlexFenlon marked this pull request as ready for review July 8, 2025 10:12
@AlexFenlon AlexFenlon requested review from a team as code owners July 8, 2025 10:12
@AlexFenlon AlexFenlon merged commit 8f9152b into main Jul 8, 2025
10 checks passed
@AlexFenlon AlexFenlon deleted the nic-release-5.1 branch July 8, 2025 14:27
lamATnginx pushed a commit that referenced this pull request Jul 15, 2025
* Add Rate Limit variable condition

* NIC 5.1.0 Release

* Apply suggestions from code review

Co-authored-by: Alan Dooley <[email protected]>

* update tech specs

* Apply suggestions from code review

Co-authored-by: Mike Jang <[email protected]>

* Update content/nic/technical-specifications.md

---------

Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Mike Jang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nic Issues related to NGINX Ingress Controller tooling Back end, repository, Hugo, and all things not related to content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants