Skip to content

Conversation

Chetan-99
Copy link
Contributor

No description provided.

@Chetan-99 Chetan-99 requested a review from a team as a code owner June 26, 2025 11:22
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager labels Jun 26, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/747/

@Chetan-99
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@Chetan-99 Chetan-99 self-assigned this Jun 30, 2025
@JTorreG
Copy link
Contributor

JTorreG commented Jun 30, 2025

I have some concerns about the number of call outs being added.

We should try to keep the number of callouts at a minimum.

@Chetan-99 Chetan-99 enabled auto-merge (squash) June 30, 2025 13:08
@travisamartin
Copy link
Contributor

How long do we need to continue documenting 2.18 and earlier? The doc covers deployments for <= 2.18, 2.19.x, and 2.20, and it's starting to get a little convoluted.

Copy link
Contributor

@balakoteswar balakoteswar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chetan-99 Chetan-99 merged commit c005b50 into main Jul 2, 2025
10 checks passed
@Chetan-99 Chetan-99 deleted the nim-k8s-docs2 branch July 2, 2025 09:21
lamATnginx pushed a commit that referenced this pull request Jul 15, 2025
* fix: Added instruction to install NIM 2.19.0

* fix: minor fixes

* fix: call out about the new helm chart versioning

* fix: added openshift details in nim k8s docs

* fix: minor changes

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Jon Torre <[email protected]>

* fix: Update deploy-using-helm.md

* fix: Update deploy-using-helm.md

* fix: combined call-out of renaming and versioning

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* Update content/nim/deploy/kubernetes/deploy-using-helm.md

Co-authored-by: Travis Martin <[email protected]>

* fix: minor yaml fixes

* fix: minor changes

---------

Co-authored-by: Jon Torre <[email protected]>
Co-authored-by: Travis Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants