Skip to content

fix: add v2 v3 docker pull steps #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 8, 2025
Merged

fix: add v2 v3 docker pull steps #786

merged 6 commits into from
Jul 8, 2025

Conversation

JTorreG
Copy link
Contributor

@JTorreG JTorreG commented Jul 3, 2025

Proposed changes

Need separate docker pull steps for Agent v2 and Agent v3

Closes #784

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) product/nginx-one Issues related to NGINX One Console labels Jul 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/786/

@JTorreG JTorreG marked this pull request as ready for review July 7, 2025 09:39
@JTorreG JTorreG requested a review from a team as a code owner July 7, 2025 09:39
@JTorreG JTorreG enabled auto-merge (squash) July 8, 2025 11:01
@JTorreG JTorreG merged commit 0349e44 into main Jul 8, 2025
6 checks passed
@JTorreG JTorreG deleted the issue-784 branch July 8, 2025 11:01
lamATnginx pushed a commit that referenced this pull request Jul 15, 2025
@JTorreG @ADubhlaoich @lamATnginx
fix: add v2 v3 docker pull steps (#786)
baef8c7 
* fix: add v2 v3 docker pull steps

* fix: fix variable anme

* fix: clarification

---------

Co-authored-by: Alan Dooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@mjang mjang mjang approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pulling container images. Different commands required for Agent v2 and v3

3 participants

@JTorreG @ADubhlaoich @mjang