Skip to content

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

Since NGINX One Console has been released, we are able to uncover NIC's connection guide and fixes

  • Update NGINX Agent default endpoint to correctly connect to NGINX One Console
  • Add additonal NGINX Agent fields to NIC helm chart values doc.
  • remove out of date nic n1 integration guide

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@AlexFenlon AlexFenlon requested review from a team as code owners July 16, 2025 10:56
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console product/nic Issues related to NGINX Ingress Controller labels Jul 16, 2025
@AlexFenlon AlexFenlon marked this pull request as draft July 16, 2025 11:00
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/823/

@AlexFenlon AlexFenlon marked this pull request as ready for review July 16, 2025 11:03
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes

Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid merging this PR until we've had a chance to talk in today's call

@shaun-nx shaun-nx self-requested a review July 17, 2025 08:14
@vepatel vepatel dismissed shaun-nx’s stale review July 17, 2025 08:40

requesting re-review

@AlexFenlon AlexFenlon merged commit 44bd9f6 into main Jul 17, 2025
10 checks passed
@AlexFenlon AlexFenlon deleted the nic-n1-fix branch July 17, 2025 08:52
@AlexFenlon AlexFenlon self-assigned this Jul 17, 2025
@AlexFenlon AlexFenlon moved this to Done 🚀 in NGINX Ingress Controller Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console product/nic Issues related to NGINX Ingress Controller

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

6 participants