Skip to content

Remove axios dependency #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Remove axios dependency #875

merged 2 commits into from
Jul 23, 2025

Conversation

@lamATnginx
Copy link
Contributor

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/569

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this Jul 22, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner July 22, 2025 16:14
@lamATnginx lamATnginx added the dependencies Pull requests that update a dependency file label Jul 22, 2025
@github-actions github-actions bot added the tooling Back end, repository, Hugo, and all things not related to content label Jul 22, 2025
@github-actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/875/

mjang
mjang reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see updates for form-data

@lamATnginx
Copy link
Contributor Author

lamATnginx commented Jul 22, 2025 •
edited
Loading

I don't see updates for form-data

It is deleted in package-lock.json. Here - https://github.com/nginx/documentation/pull/875/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519L1357

@mjang
Copy link
Contributor

mjang commented Jul 22, 2025

I don't see updates for form-data

It is deleted in package-lock.json. Here - https://github.com/nginx/documentation/pull/875/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519L1357

Oh that's right! Should we also delete the form-data-encoder package?

@TasoOneAsia TasoOneAsia mentioned this pull request Jul 22, 2025
Closed
@TasoOneAsia
Copy link
Member

Oh that's right! Should we also delete the form-data-encoder package?

This is an unrelated transitive dependency being used by got and should be fine to keep as there are no security advisories.

mjang
mjang approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on questions / answers in the PR discussion

@lamATnginx lamATnginx merged commit 5fa6edb into main Jul 23, 2025
10 checks passed
@lamATnginx lamATnginx deleted the formdata-update branch July 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjang mjang mjang approved these changes

@y82 y82 y82 approved these changes

Assignees

@lamATnginx lamATnginx

Labels

dependencies Pull requests that update a dependency file tooling Back end, repository, Hugo, and all things not related to content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lamATnginx @mjang @TasoOneAsia @y82