Skip to content

fix: Async issues with UI validation workflow #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix: Async issues with UI validation workflow #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/search.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { handleConsentPopup, waitFor } from '../tests/utils/commonUtils.ts'
test.describe("Testing search page", () => {
test('Searchbar is visible', async ({ page }) => {
await page.goto('/');
await waitFor(() => handleConsentPopup(page));
await waitFor(async () => await handleConsentPopup(page));

const searchBox = page.locator('.CoveoSearchbox').first();
const searchButton = page.locator('.CoveoSearchButton');
Expand Down
3 changes: 1 addition & 2 deletions tests/utils/commonUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ export async function handleConsentPopup(page: Page) {
const consentContent = page.locator('#truste-consent-content');
const isConsentContentVisibile = await consentContent.isVisible();
if(isConsentContentVisibile) {
const consentButton = page.locator('#truste-consent-required').first();
console.log((await consentButton.all()).length);
const consentButton = page.locator('#truste-consent-required');
expect(consentButton).toBeVisible();
await consentButton.click();
}
Expand Down
Loading