Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 7, 2024

Proposed changes

Replace expired default-server-secret & cafe.example.com secrets by using centralised re-usable secrets

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 7, 2024 17:18
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Nov 7, 2024
@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.73%. Comparing base (c4c6114) to head (95b20a9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6773      +/-   ##
==========================================
- Coverage   52.74%   52.73%   -0.01%     
==========================================
  Files          89       89              
  Lines       20824    20824              
==========================================
- Hits        10983    10981       -2     
- Misses       9387     9389       +2     
  Partials      454      454              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 closed this Dec 20, 2024
@pdabelf5 pdabelf5 deleted the cert-update branch January 16, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code tests Pull requests that update tests

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants