Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

Proposed changes

Remove unused NewDefaultGlobalConfigParams() & NewGlobalConfigParamsWithTLSPassthrough()

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 14, 2024 09:04
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.47%. Comparing base (214d9f1) to head (e6b93fd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6806      +/-   ##
==========================================
+ Coverage   53.46%   53.47%   +0.01%     
==========================================
  Files          89       88       -1     
  Lines       20218    20195      -23     
==========================================
- Hits        10809    10800       -9     
+ Misses       8965     8951      -14     
  Partials      444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) November 14, 2024 10:37
@pdabelf5 pdabelf5 merged commit d2a70a4 into main Nov 14, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the remove-unused-functions branch November 14, 2024 10:41
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title remove unused functions Remove unused functions Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants