Skip to content

expand special secret validation #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

expand special secret validation #6825

wants to merge 1 commit into from

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 19, 2024 •
edited
Loading

Proposed changes

Allow special secret validation to be expanded to other secret types, not just TLS secrets

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 19, 2024 16:52
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 19, 2024
@pdabelf5 pdabelf5 closed this Nov 20, 2024
@pdabelf5 pdabelf5 deleted the special-secret-validation branch December 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

go Pull requests that update Go code

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pdabelf5