Skip to content

Conversation

@haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Dec 10, 2024

Proposed changes

Re-add FIPS related images to tests, image patching & release process. closes #5914

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 10, 2024
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@haywoodsh haywoodsh force-pushed the chore/add-fips-images-to-pipeline branch from 06b9438 to 151518f Compare December 10, 2024 10:04
@haywoodsh haywoodsh changed the title test add fips image Dec 10, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 11, 2024
@github-actions
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6948/

@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Dec 11, 2024
@haywoodsh haywoodsh changed the title add fips image Re-add FIPs images to tests, image patching & release Dec 12, 2024
@haywoodsh haywoodsh marked this pull request as ready for review December 12, 2024 11:38
@haywoodsh haywoodsh requested review from a team as code owners December 12, 2024 11:38
@haywoodsh haywoodsh enabled auto-merge (squash) December 12, 2024 12:09
@haywoodsh haywoodsh merged commit 606b33b into main Dec 12, 2024
81 checks passed
@haywoodsh haywoodsh deleted the chore/add-fips-images-to-pipeline branch December 12, 2024 12:25
nginx-bot pushed a commit that referenced this pull request Dec 12, 2024
* add fips image to pipeline
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>

* re-add fips images to patching and release

* add fips images to tech specs

* remove FIPS note from release notes

* switch tests for fips

---------

Signed-off-by: Haywood Shannon <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Re-add FIPS related images to tests, image patching & release process

6 participants