Skip to content

Conversation

@jjngx
Copy link
Contributor

@jjngx jjngx commented Dec 12, 2024

Proposed changes

This PR addresses security complains about 3rd party dependencies (K8s packages).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner December 12, 2024 11:58
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 12, 2024
@jjngx jjngx added needs cherry pick Cherry pick this PR into a release branch and removed dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 12, 2024
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.54%. Comparing base (6ce3e72) to head (790cdad).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6970      +/-   ##
==========================================
- Coverage   52.57%   52.54%   -0.03%     
==========================================
  Files          88       88              
  Lines       20789    20803      +14     
==========================================
+ Hits        10929    10931       +2     
- Misses       9403     9417      +14     
+ Partials      457      455       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 12, 2024
@jjngx jjngx merged commit f97a3e3 into main Dec 12, 2024
79 checks passed
@jjngx jjngx deleted the chore/apiserver-patch branch December 12, 2024 13:02
nginx-bot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants