Add helm knob to control ClusterRoleBinding creation#7578
Closed
zaccari wants to merge 2 commits intonginx:mainfrom
Closed
Add helm knob to control ClusterRoleBinding creation#7578zaccari wants to merge 2 commits intonginx:mainfrom
ClusterRoleBinding creation#7578zaccari wants to merge 2 commits intonginx:mainfrom
Conversation
A knob already exists for the ClusterRole. When deploying `nginx-ingress` into multiple namespaces within the same cluster, it is possible for the ClusterRoleBinding to be overwritten, causing the controllers to get into a bad state with their RBAC. Having this knob in place allows an operator to own the CRB and not compete against the helm chart when `rbac.clusterrolebinding.create: false`.
github-actions
bot
added
documentation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
Contributor
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
This PR was closed because it has been stalled for 10 days with no activity. |
github-actions
bot
removed
documentation
Contributor
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
This PR was closed because it has been stalled for 10 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a knob to toggle creation of the
ClusterRoleBinding, closing #7577. This is a follow-up to #5228.Checklist
Before creating a PR, run through this checklist and mark each as complete.