Skip to content

Conversation

@cdxker
Copy link
Contributor

@cdxker cdxker commented Apr 30, 2025

Proposed changes

Removing extra configuration parameters that don't seem to be used in the helm chart.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@cdxker cdxker requested review from a team as code owners April 30, 2025 21:27
@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 30, 2025
@cdxker
Copy link
Contributor Author

cdxker commented May 1, 2025

I have hereby read the F5 CLA and agree to its terms.

@cdxker
Copy link
Contributor Author

cdxker commented May 1, 2025

recheck

@pdabelf5
Copy link
Collaborator

pdabelf5 commented May 1, 2025

@cdxker I think the trailing . is causing the CLA check to fail. Can you please re-comment without the full stop? Thanks

@cdxker
Copy link
Contributor Author

cdxker commented May 1, 2025

I have hereby read the F5 CLA and agree to its terms

@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label May 1, 2025
@pdabelf5 pdabelf5 moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller May 1, 2025
@pdabelf5 pdabelf5 merged commit df4a15d into nginx:main May 1, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller May 1, 2025
pdabelf5 pushed a commit that referenced this pull request May 1, 2025
docs: removed unused configurations parameters for helm installation guide
@AlexFenlon AlexFenlon removed the needs cherry pick Cherry pick this PR into a release branch label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

4 participants