Move proxy values balancing to the beginning of parsing #8133

javorszky · 2025-08-13T21:32:54Z

Proposed changes

This PR moves the proxy values balancing from the template helpers to the time where the annotations and config maps are being parsed. There are a few notable changes:

proxy value types (like 4 8k and 16k) are now custom structs with iota constants for the unit (k, m), and uint64 for the numbers. This guarantees that once the values are parsed and corrected, they won't become invalid later through any changes, and we can offload a lot of the error checking to the compiler. One such is that we know none of the values will be negative, because a uint can't be negative
some tests had to be changed. For example previously an empty proxy_buffers value passed in via a configmap would generate a bad config, now it gets auto-corrected to the default 2 4k value. This is the cost of moving the proxy balancing to be right after parsing the values
similarly the e2e pytest also had to change because if the passed in values are actually invalid, then the result will have those configuration items missing, rather than present, but with invalid values
I brought on and reused most of the tests that were in the PR originally, though some of them had to be changed. The logic of what value stays, and what values move around it was fuzzy. Right now if proxy-buffers is not defined, that gets set to the default value of 2 4k, and everything else gets brought down to fit into that one
rules of how the values relate to each other are based on the NGINX source code
- proxy_buffers: https://github.com/nginx/nginx/blob/master/src/http/modules/ngx_http_proxy_module.c#L3763-L3767
- proxy_busy_buffers_size: https://github.com/nginx/nginx/blob/master/src/http/modules/ngx_http_proxy_module.c#L3787-L3804
those rules also mean that the proxy_buffers_size is at most all of proxy_buffers minus one buffer size

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

pdabelf5 · 2025-08-14T08:12:12Z

pkg/apis/configuration/v1/types.go

afaik should only be used for CRD generation

codecov · 2025-08-14T08:25:48Z

Codecov Report

❌ Patch coverage is 69.10377% with 131 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.64%. Comparing base (060af62) to head (d863c20).

Files with missing lines	Patch %	Lines
pkg/apis/configuration/validation/virtualserver.go	20.68%	23 Missing ⚠️
internal/configs/annotations.go	31.25%	20 Missing and 2 partials ⚠️
internal/validation/validation.go	60.37%	19 Missing and 2 partials ⚠️
internal/validation/data_types.go	89.14%	14 Missing and 5 partials ⚠️
internal/k8s/configuration.go	39.13%	9 Missing and 5 partials ⚠️
internal/configs/configmaps.go	75.67%	4 Missing and 5 partials ⚠️
internal/configs/parsing_helpers.go	83.78%	4 Missing and 2 partials ⚠️
internal/k8s/validation.go	62.50%	2 Missing and 4 partials ⚠️
pkg/apis/configuration/validation/common.go	37.50%	4 Missing and 1 partial ⚠️
cmd/nginx-ingress/main.go	0.00%	4 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8133      +/-   ##
==========================================
+ Coverage   53.35%   53.64%   +0.28%     
==========================================
  Files          90       91       +1     
  Lines       21912    22302     +390     
==========================================
+ Hits        11691    11963     +272     
- Misses       9744     9836      +92     
- Partials      477      503      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AlexFenlon · 2025-08-14T11:29:17Z

Docs PR: nginx/documentation#917

Copilot

Pull Request Overview

This PR moves proxy buffer value balancing from template helpers to the config/annotation parsing phase. It introduces custom data types for size and buffer configurations to ensure type safety and consistency, along with validation rules based on NGINX source code requirements.

Key changes:

Introduces SizeWithUnit and NumberSizeConfig structs with type-safe parsing and validation
Implements BalanceProxyValues function to normalize proxy buffer relationships according to NGINX constraints
Updates test expectations to handle auto-correction of invalid proxy buffer configurations

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`internal/validation/data_types.go`	Defines new custom types for size and buffer configurations with validation logic
`internal/configs/configmaps.go`	Updates config parsing to use new types and balance proxy values
`internal/configs/annotations.go`	Updates annotation parsing to use new types and balance proxy values
`tests/suite/test_virtual_server_configmap_keys.py`	Updates test to handle corrected proxy buffer behavior
`internal/configs/virtualserver.go`	Updates template generation to use string representation of new types

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

internal/validation/validation.go

internal/validation/data_types.go

internal/configs/configmaps.go

internal/validation/data_types.go

…nabled and vise versa

internal/validation/data_types.go

cmd/nginx-ingress/flags.go

Signed-off-by: AlexFenlon <[email protected]>

…rams

github-actions · 2025-08-28T10:02:43Z

Package Report

gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx, 1.29.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-agent, 3.3.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx, 1.29.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-agent, 3.3.0~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-agent, 3.3.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus, 35-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-njs, 35+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-otel, 35+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-fips-check, 35+0.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-agent, 3.3.0~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-attack-signatures, 2025.08.14-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-threat-campaigns, 2025.08.25-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-agent, 2.42.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-module-plus, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-plugin, 6.20.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-agent, 2.42.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-appprotect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect, 35+5.498.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-attack-signatures, 2025.08.14-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-threat-campaigns, 2025.08.25-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f, nginx-agent, 2.42.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx, 1.29.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-agent, 3.3.0, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx, 1.29.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-agent, 3.3.0, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-agent, 3.3.0, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine, nginx-agent, 3.3.0, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-agent, 3.3.0, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-agent, 3.3.0, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-agent, 2.42.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-appprotect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, app-protect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, app-protect-attack-signatures, 2025.08.14-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, app-protect-threat-campaigns, 2025.08.25-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-agent, 2.42.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, nginx-plus-module-appprotect, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, app-protect-module-plus, 35.5.498.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-alpine-fips, app-protect-plugin, 6.20.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx, 1.29.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-module-njs, 1.29.1+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-agent, 3.3.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx, 1.29.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-module-njs, 1.29.1+0.9.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-agent, 3.3.0-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-agent, 3.3.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus, 35-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-agent, 3.3.0-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-agent, 2.42.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-attack-signatures, 2025.08.14-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-threat-campaigns, 2025.08.25-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-agent, 2.42.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-module-plus, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-plugin, 6.20.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-agent, 2.42.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-appprotect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, app-protect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, app-protect-attack-signatures, 2025.08.14-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, app-protect-threat-campaigns, 2025.08.25-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-agent, 2.42.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, nginx-plus-module-appprotect, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, app-protect-module-plus, 35+5.498.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi8, app-protect-plugin, 6.20.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-appprotect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, nginx-agent, 2.42.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect, 35+5.498.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-attack-signatures, 2025.08.14-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-threat-campaigns, 2025.08.25-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-1d86e46cc97e1958bc782eeaf79df37f-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64

internal/configs/parsing_helpers_test.go

Co-authored-by: Paul Abel <[email protected]> Signed-off-by: AlexFenlon <[email protected]>

Signed-off-by: AlexFenlon <[email protected]> Co-authored-by: Alex Fenlon <[email protected]> # Conflicts: # charts/nginx-ingress/values.yaml

javorszky requested a review from a team as a code owner August 13, 2025 21:32

github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code python Pull requests that update Python code labels Aug 13, 2025

javorszky changed the base branch from feat/safe-buffer-config to main August 14, 2025 08:21

AlexFenlon mentioned this pull request Aug 14, 2025

Add Safer Proxy_Buffer Config #8088

Closed

6 tasks

AlexFenlon linked an issue Aug 14, 2025 that may be closed by this pull request

Safe proxy buffer configuration #8004

Closed

5 tasks

danielnginx requested a review from Copilot August 14, 2025 12:58

Copilot AI reviewed Aug 14, 2025

View reviewed changes

AlexFenlon mentioned this pull request Aug 18, 2025

feat: Add proxy-busy-buffers-size to NIC nginx/documentation#917

Merged

5 tasks

github-advanced-security bot found potential problems Aug 20, 2025

View reviewed changes

internal/validation/data_types.go Fixed Show fixed Hide fixed

AlexFenlon and others added 16 commits August 20, 2025 09:31

add helper function to enable proxy_buffers if proxy_buffer_size is e…

07b9230

…nabled and vise versa

add a safe way to enable proxy_buffers and proxy_buffer_size

820d620

add nginx.org/proxy-busy-buffers-size annotation to ingress

e9f0274

add proxy-busy-buffer-size to configmap, improve validation

f32d163

rename ProxyBusyBufferSize to ProxyBusyBuffersSize to be more accurate

1573082

Add ProxyBusyBuffersSize to VirtualServer as busy-buffers-size

b46e413

make validation better

ded1e22

make validation better

dc78b16

Update tests

be0fa51

Update tests, improve validation

14e6a4d

fix validation

a7bcc2e

Put back the proxy max temp filesize data

5372bb8

Create a new typed unit to store sizes and offsets

c67ff54

Move new units to internal configs

57afcfb

Move data types to their own file

ce03f44

Move proxy units into common package

14491db

github-advanced-security bot found potential problems Aug 27, 2025

View reviewed changes

internal/validation/data_types.go Fixed Show fixed Hide fixed

address comments on pr

6075682

AlexFenlon reviewed Aug 27, 2025

View reviewed changes

cmd/nginx-ingress/flags.go Outdated Show resolved Hide resolved

AlexFenlon and others added 5 commits August 27, 2025 10:27

Update cmd/nginx-ingress/flags.go

248fae7

Signed-off-by: AlexFenlon <[email protected]>

move isDirectiveAutoadjustEnabled from Configurator to StaticConfigPa…

0305674

…rams

fix ingress annotation not being enabled

3b7bab0

Merge branch 'main' into feat/fixed-safe-buffer-config

b7a9875

Merge branch 'main' into feat/fixed-safe-buffer-config

3167c1b

Merge branch 'main' into feat/fixed-safe-buffer-config

349c087

AlexFenlon enabled auto-merge (squash) August 28, 2025 10:32

pdabelf5 previously approved these changes Aug 28, 2025

View reviewed changes

javorszky added 2 commits August 29, 2025 11:31

Merge branch 'main' into feat/fixed-safe-buffer-config

f00c78d

Rename constants for consistency

1800e6d

javorszky dismissed pdabelf5’s stale review via 1800e6d August 29, 2025 09:57

javorszky and others added 3 commits August 29, 2025 12:00

Clamp the number of buffers to the correct place

7f9712d

Do not clamp without flag

dc6907d

add more test cases

a93e96e

pdabelf5 requested changes Aug 29, 2025

View reviewed changes

internal/configs/parsing_helpers_test.go Outdated Show resolved Hide resolved

internal/configs/parsing_helpers_test.go Outdated Show resolved Hide resolved

AlexFenlon and others added 2 commits September 1, 2025 09:20

Update internal/configs/parsing_helpers_test.go

cf9083a

Co-authored-by: Paul Abel <[email protected]> Signed-off-by: AlexFenlon <[email protected]>

fix tests

d863c20

AlexFenlon requested review from pdabelf5 and vepatel September 1, 2025 09:30

Merge branch 'main' into feat/fixed-safe-buffer-config

7fd146e

pdabelf5 approved these changes Sep 1, 2025

View reviewed changes

Merge branch 'main' into feat/fixed-safe-buffer-config

a35cf61

vepatel approved these changes Sep 1, 2025

View reviewed changes

AlexFenlon merged commit 81ca457 into main Sep 1, 2025
81 checks passed

AlexFenlon deleted the feat/fixed-safe-buffer-config branch September 1, 2025 17:23

AlexFenlon added a commit that referenced this pull request Sep 9, 2025

Add Safe Proxy Buffer Configuration Adjustments (#8133)

ada8720

Signed-off-by: AlexFenlon <[email protected]> Co-authored-by: Alex Fenlon <[email protected]> # Conflicts: # charts/nginx-ingress/values.yaml

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move proxy values balancing to the beginning of parsing #8133

Move proxy values balancing to the beginning of parsing #8133

Uh oh!

javorszky commented Aug 13, 2025 •

edited

Loading

Uh oh!

pdabelf5 commented Aug 14, 2025

Uh oh!

codecov bot commented Aug 14, 2025 •

edited

Loading

Uh oh!

AlexFenlon commented Aug 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Move proxy values balancing to the beginning of parsing #8133

Move proxy values balancing to the beginning of parsing #8133

Uh oh!

Conversation

javorszky commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Checklist

Uh oh!

pdabelf5 commented Aug 14, 2025

Uh oh!

codecov bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AlexFenlon commented Aug 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

javorszky commented Aug 13, 2025 •

edited

Loading

codecov bot commented Aug 14, 2025 •

edited

Loading

github-actions bot commented Aug 28, 2025 •

edited

Loading