Skip to content

Update k8s variable syntax for minikube & kind #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2025
Merged

Update k8s variable syntax for minikube & kind #8347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c255668
Update k8s versions for minikube
pdabelf5 Oct 3, 2025
3e2e730
fix tests
pdabelf5 Oct 3, 2025
c3f77ca
Merge branch 'main' into chore/minikube-updates
pdabelf5 Oct 3, 2025
b064dae
Merge branch 'main' into chore/minikube-updates
pdabelf5 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/smoke-tests/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ runs:
- name: Deploy Kubernetes
id: k8s
run: |
make -f tests/Makefile create-kind-cluster K8S_CLUSTER_NAME=${{ github.run_id }} K8S_CLUSTER_VERSION=${{ inputs.k8s-version }} K8S_TIMEOUT=${{ inputs.k8s-timeout }}
make -f tests/Makefile create-kind-cluster K8S_CLUSTER_NAME=${{ github.run_id }} K8S_CLUSTER_VERSION=v${{ inputs.k8s-version }} K8S_TIMEOUT=${{ inputs.k8s-timeout }}
make -f tests/Makefile image-load REGISTRY="" PREFIX=${{ inputs.image-name }} TAG=${{ inputs.tag }} K8S_CLUSTER_NAME=${{ github.run_id }}
label="${{ inputs.label }}"
nospaces="${label// /_}"
Expand Down
4 changes: 2 additions & 2 deletions tests/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ run-tests-in-kind: ## Run tests in Kind
create-kind-cluster: $(KIND_KUBE_CONFIG_FOLDER) ## Create a Kind K8S cluster
@kind create cluster \
--name $(K8S_CLUSTER_NAME) \
--image=kindest/node:v$(K8S_CLUSTER_VERSION) \
--image=kindest/node:$(K8S_CLUSTER_VERSION) \
--config=<(sed 's/dual/${IP_FAMILY}/' $(ROOT_DIR)/tests/ci-files/ci-kind-config.yaml) \
--wait $(K8S_TIMEOUT)
@kind get kubeconfig --name $(K8S_CLUSTER_NAME) --internal > $(KIND_KUBE_CONFIG_FOLDER)/config
Expand Down Expand Up @@ -164,7 +164,7 @@ run-tests-in-minikube: ## Run tests in Minikube

.PHONY: create-mini-cluster
create-mini-cluster: $(MINIKUBE_KUBE_CONFIG_FOLDER) ## Create a Minikube K8S cluster
@minikube start --kubernetes-version=v$(K8S_CLUSTER_VERSION) \
@minikube start --kubernetes-version=$(K8S_CLUSTER_VERSION) \
&& KUBECONFIG=$(MINIKUBE_KUBE_CONFIG_FOLDER)/config minikube update-context \
&& KUBECONFIG=$(MINIKUBE_KUBE_CONFIG_FOLDER)/config kubectl config set-cluster minikube --server=https://minikube:8443

Expand Down
Loading