Skip to content

Update goproxy logic & cleanup netrc #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
Merged

Update goproxy logic & cleanup netrc #8421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d2cf16
Update goproxy logic & cleanup netrc
pdabelf5 Oct 13, 2025
ba2e43e
don't echo empty variable
pdabelf5 Oct 13, 2025
07f8117
Merge branch 'main' into chore/update-proxy-logic
pdabelf5 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,10 @@ jobs:
# with:
# assertion-doc: ${{ steps.assertiondoc.outputs.assertion-document-path }}

- name: Cleanup netrc
run: rm -f $HOME/.netrc
if: ${{ always() }}

build-docker:
name: Build Docker OSS
needs: [binaries]
Expand Down
20 changes: 14 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@ jobs:
echo "chart_version=${HELM_CHART_VERSION}" >> $GITHUB_OUTPUT
forked_workflow=${{ (github.event.pull_request && github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name) || github.repository != 'nginx/kubernetes-ingress' }}
echo "forked_workflow=${forked_workflow}" >> $GITHUB_OUTPUT
go_proxy="https://proxy.golang.org,direct"
if [ "$forked_workflow" = "false" ]; then
go_proxy="${{ secrets.ARTIFACTORY_DEV_ENDPOINT }}"
elif [ "${{ github.ref_name }}" = "main" ] || [[ "${{ github.ref_name }}" =~ "release-" ]]; then
go_proxy="${{ secrets.ARTIFACTORY_ENDPOINT }}"
if [ "$forked_workflow" = "false" ] && [ "${{ github.ref_name }}" != "${{ github.event.repository.default_branch }}" ]; then
echo "go_proxy=${{ secrets.ARTIFACTORY_DEV_ENDPOINT }}" >> $GITHUB_OUTPUT
elif [ "${{ github.ref_name }}" = "${{ github.event.repository.default_branch }}" ] || [[ "${{ github.ref_name }}" =~ "release-" ]]; then
echo "go_proxy=${{ secrets.ARTIFACTORY_ENDPOINT }}" >> $GITHUB_OUTPUT
else
echo "go_proxy=https://proxy.golang.org,direct" >> $GITHUB_OUTPUT
fi
echo "go_proxy=${go_proxy}" >> $GITHUB_OUTPUT
./.github/scripts/variables.sh go_code_md5 >> $GITHUB_OUTPUT
./.github/scripts/variables.sh docker_md5 >> $GITHUB_OUTPUT
./.github/scripts/variables.sh build_tag >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -241,6 +241,10 @@ jobs:
make telemetry-schema && git diff --name-only --exit-code internal/telemetry
if: ${{ needs.checks.outputs.binary_cache_hit != 'true' }}

- name: Cleanup netrc
run: rm -f $HOME/.netrc
if: ${{ always() }}

unit-tests:
name: Unit Tests
runs-on: ubuntu-24.04
Expand Down Expand Up @@ -290,6 +294,10 @@ jobs:
install-go: false
if: ${{ needs.checks.outputs.binary_cache_hit != 'true' && (inputs.run_tests && inputs.run_tests || true) }}

- name: Cleanup netrc
run: rm -f $HOME/.netrc
if: ${{ always() }}

build-artifacts:
name: Build Artifacts
needs: [checks, unit-tests, verify-codegen]
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/image-promotion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ jobs:
with:
sarif_file: govulncheck.sarif

- name: Cleanup netrc
run: rm -f $HOME/.netrc
if: ${{ always() }}

build-artifacts:
name: Build Artifacts
needs: [checks]
Expand Down
Loading