Skip to content

Remove unused pytest option #8531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

Remove unused pytest option #8531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c205311
Remove unused pytest option
pdabelf5 Nov 12, 2025
33ebb89
remove variable from makefile
pdabelf5 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/actions/smoke-tests/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ inputs:
label:
description: Label for test
required: false
azure-ad-secret:
description: Azure Active Directory secret for JWKs
required: false
registry-token:
description: JWT token for accessing container registry
required: false
Expand Down Expand Up @@ -103,7 +100,6 @@ runs:
--self-contained-html \
--durations=10 \
--show-ic-logs=yes \
--ad-secret=${{ inputs.azure-ad-secret }} \
--plus-jwt=${{ inputs.plus-jwt }} \
-m ${{ inputs.marker != '' && inputs.marker || '""' }}
working-directory: ./tests
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ jobs:
marker: ${{ matrix.images.marker != '' && matrix.images.marker || '' }}
k8s-version: ${{ matrix.k8s }}
label: ${{ matrix.images.label }}
azure-ad-secret: ${{ secrets.AZURE_AD_AUTOMATION }}
registry-token: ${{ steps.auth.outputs.access_token }}
test-image: "gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/test-runner:${{ hashFiles('./tests/requirements.txt', './tests/Dockerfile') || 'latest' }}"
plus-jwt: ${{ secrets.PLUS_JWT }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/setup-smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ jobs:
marker: ${{ inputs.marker != '' && inputs.marker || '' }}
label: ${{ inputs.label }}
k8s-version: ${{ inputs.k8s-version }}
azure-ad-secret: ${{ secrets.AZURE_AD_AUTOMATION }}
registry-token: ${{ steps.auth.outputs.access_token }}
test-image: "gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/test-runner:${{ hashFiles('./tests/requirements.txt', './tests/Dockerfile') || 'latest' }}"
plus-jwt: ${{ secrets.PLUS_JWT }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/single-image-regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ jobs:
marker: ${{ inputs.marker }}
label: "${{ inputs.image }} regression"
k8s-version: ${{ inputs.k8s-version }}
azure-ad-secret: ${{ secrets.AZURE_AD_AUTOMATION }}
registry-token: ${{ steps.auth.outputs.access_token }}
test-image: "gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/test-runner:${{ hashFiles('./tests/requirements.txt', './tests/Dockerfile') }}"
plus-jwt: ${{ secrets.PLUS_JWT }}
6 changes: 0 additions & 6 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,6 @@ def pytest_addoption(parser) -> None:
default=NS_COUNT,
help="Number for namespaces to deploy for use in test_multiple_ns_perf.py",
)
parser.addoption(
"--ad-secret",
action="store",
default=os.environ.get("AZURE_AD_AUTOMATION"),
help="Azure active directory secret for JWKs",
)
parser.addoption(
"--num",
action="store",
Expand Down
Loading