Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors variable and struct field names to improve code clarity and organization. The changes focus on making naming more descriptive and moving policy-related structures to a more appropriate location.
Changes:
- Renamed function parameter
ptoncpfor NginxCfgParams in ingress configuration functions - Renamed local variable
nginxCfgtominionNginxCfgfor clarity in minion processing - Refactored struct field names in
policyOwnerDetails:vsName→parentName,vsNamespace→parentNamespace - Moved
policyOwnerDetailsandpolicyOptionsstructs from virtualserver.go to policy.go - Updated pre-commit configuration to use local golangci-lint installation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/configs/virtualserver.go | Updated struct field names and removed struct definitions that were moved to policy.go |
| internal/configs/policy_test.go | Updated test struct initialization to use new field names |
| internal/configs/policy.go | Added struct definitions for policyOwnerDetails and policyOptions, updated all references to use new field names |
| internal/configs/ingress.go | Renamed function parameter from p to ncp and local variable nginxCfg to minionNginxCfg |
| .pre-commit-config.yaml | Changed golangci-lint from remote to local hook with updated configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9215 +/- ##
==========================================
+ Coverage 53.95% 54.26% +0.30%
==========================================
Files 91 95 +4
Lines 18692 18888 +196
==========================================
+ Hits 10086 10249 +163
- Misses 8075 8095 +20
- Partials 531 544 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Package ReportDetailsgcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx, 1.29.5-1~trixie, amd64gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-module-njs, 1.29.5+0.9.5-1~trixie, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-module-otel, 1.29.5+0.1.2-1~trixie, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-agent, 3.7.1~trixie, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx, 1.29.5-1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-module-njs, 1.29.5+0.9.5-1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-module-otel, 1.29.5+0.1.2-1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-agent, 3.7.1~trixie, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus, 36-3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-agent, 3.7.1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus, 36-3~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-njs, 36+0.9.5-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-otel, 36+0.1.2-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-fips-check, 36+0.1-1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-agent, 3.7.1~bookworm, arm64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus, 36-3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-appprotect, 36+5.575.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect, 36+5.575.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-attack-signatures, 2026.02.18-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-threat-campaigns, 2026.02.16-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-agent, 2.45.2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus, 36-3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-appprotect, 36+5.575.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-module-plus, 36+5.575.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-plugin, 6.25.0-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-agent, 2.45.2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus, 36-3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-appprotectdos, 36+4.8.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-dos, 36+4.8.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus, 36-3~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-appprotect, 36+5.575.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect, 36+5.575.2-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-attack-signatures, 2026.02.18-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-threat-campaigns, 2026.02.16-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-plus-module-appprotectdos, 36+4.8.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, app-protect-dos, 36+4.8.3-1~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e, nginx-agent, 2.45.2~bookworm, amd64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx, 1.29.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-module-njs, 1.29.5.0.9.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-module-otel, 1.29.5.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-agent, 3.7.1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx, 1.29.5-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-module-njs, 1.29.5.0.9.5-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-module-otel, 1.29.5.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-agent, 3.7.1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus, 36-r3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus-module-njs, 36.0.9.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus-module-otel, 36.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus-module-fips-check, 36.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-agent, 3.7.1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus, 36-r3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus-module-njs, 36.0.9.5-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus-module-otel, 36.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-plus-module-fips-check, 36.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine, nginx-agent, 3.7.1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus, 36-r3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-agent, 3.7.1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus, 36-r3, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-agent, 3.7.1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus, 36-r3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-agent, 2.45.2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-appprotect, 36.5.575.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, app-protect, 36.5.575.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, app-protect-attack-signatures, 2026.02.18-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, app-protect-threat-campaigns, 2026.02.16-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus, 36-r3, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-agent, 2.45.2, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, nginx-plus-module-appprotect, 36.5.575.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, app-protect-module-plus, 36.5.575.2-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-alpine-fips, app-protect-plugin, 6.25.0-r1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx, 1.29.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-module-njs, 1.29.5+0.9.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-module-otel, 1.29.5+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-agent, 3.7.1-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx, 1.29.5-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-module-njs, 1.29.5+0.9.5-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-module-otel, 1.29.5+0.1.2-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-agent, 3.7.1-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus, 36-3.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-agent, 3.7.1-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus, 36-3.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-agent, 3.7.1-1, aarch64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus, 36-3.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-agent, 2.45.2-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-appprotect, 36+5.575.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect, 36+5.575.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-attack-signatures, 2026.02.18-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-threat-campaigns, 2026.02.16-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus, 36-3.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-agent, 2.45.2-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-appprotect, 36+5.575.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-module-plus, 36+5.575.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-plugin, 6.25.0-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus, 36-3.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-njs, 36+0.9.5-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-otel, 36+0.1.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-fips-check, 36+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-agent, 2.45.2-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-appprotect, 36+5.575.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, app-protect, 36+5.575.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, app-protect-attack-signatures, 2026.02.18-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, app-protect-threat-campaigns, 2026.02.16-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus, 36-3.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-njs, 36+0.9.5-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-otel, 36+0.1.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-fips-check, 36+0.1-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-agent, 2.45.2-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, nginx-plus-module-appprotect, 36+5.575.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, app-protect-module-plus, 36+5.575.2-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi8, app-protect-plugin, 6.25.0-1.el8.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus, 36-3.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-appprotectdos, 36+4.8.3-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-dos, 36+4.8.3-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus, 36-3.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-appprotect, 36+5.575.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-plus-module-appprotectdos, 36+4.8.3-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, nginx-agent, 2.45.2-1, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect, 36+5.575.2-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-attack-signatures, 2026.02.18-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-threat-campaigns, 2026.02.16-1.el9.ngx, x86_64 gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-49550fe6ac3d2192622f57c0dbc47d9e-ubi, app-protect-dos, 36+4.8.3-1.el9.ngx, x86_64 |
| args: ["-shellcheck", ""] | ||
|
|
||
| ci: | ||
| skip: [golang-diff, golangci-lint, check-jsonschema, markdownlint-cli2] |
There was a problem hiding this comment.
golang-diff needs removing to allow CI to pass
Proposed changes
refactor the following:
p NginxCfgParams->ncp NginxCfgParamsnginxCfg->minionNginxCfggolangci-lintpolicyOwnerDetailsandpolicyOptionsstructs tointernal/configs/policy.gopolicyOwnerDetails.vsNametopolicyOwnerDetails.parentNamepolicyOwnerDetails.vsNamespacetopolicyOwnerDetails.parentNamespaceChecklist
Before creating a PR, run through this checklist and mark each as complete.