ACME: define and allocate shared data structures. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACME protocol assumes short-term certificates to ensure a regular revalidation of ownership and to limit consequences of key compromise. Allowing to request certificate renewals with the same key goes agains the second goal and should not be supported without a good reason. This was an oversight inherited from the proof-of-concept code and was not supposed to be committed here.
bavshin-f5
force-pushed
the
bavshin/shared-state
branch
from
92501e2 to
165652e
Compare
xeioex
approved these changes
Jul 29, 2025
bavshin-f5
force-pushed
the
bavshin/shared-state
branch
from
165652e to
4d99b80
Compare
Improves time to readiness after a full restart of the server.
We trust the SSL library to securely clear the EVP_PKEY objects, but all the places where we may store a PEM data should be cleared by us.
bavshin-f5
force-pushed
the
bavshin/shared-state
branch
from
4d99b80 to
cde9ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ one quick fixup for #1