nginx-acme-0.1.0 #21
Merged
nginx-acme-0.1.0 #21
+85
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bavshin-f5
force-pushed
the
bavshin/release-0.1.0
branch
2 times, most recently
from
571e7c8 to
1157c4a
Compare
Starting from v2.7.0, pebble ignores certificateValidityPeriod and uses the validityPeriod from the default profie instead. The profile was removed during the review of #16, because I assumed it was redundant and the tests (with pebble v2.6.0) confirmed that.
Certain issuers don't like "null" in these fields.
bavshin-f5
force-pushed
the
bavshin/release-0.1.0
branch
4 times, most recently
from
9924e86 to
b335c08
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial version (0.1.0) of nginx-acme, an NGINX module implementing the ACME protocol for automatic certificate management. The release includes basic ACME protocol support with HTTP-01 challenge functionality.
- Initial release of nginx-acme module version 0.1.0
- Documentation improvements with corrected spelling and enhanced clarity
- Code changes to ACME types and test configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CHANGELOG.md | Adds initial changelog documenting the 0.1.0 release |
| README.md | Comprehensive documentation updates with spelling corrections and enhanced usage instructions |
| src/acme/types.rs | Updates serde attributes to skip serialization of None values instead of using defaults |
| t/lib/Test/Nginx/ACME.pm | Adds profiles configuration to the test setup |
bavshin-f5
force-pushed
the
bavshin/release-0.1.0
branch
from
b335c08 to
1756952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.